Skip to content

Commit

Permalink
fix(ci): use chromium 125 (beta) for cypress tests
Browse files Browse the repository at this point in the history
Electron 118 and Chromium 124 crash on `directediting.spec.js`.

Signed-off-by: Max <max@nextcloud.com>
  • Loading branch information
max-nextcloud committed May 1, 2024
1 parent f9996c0 commit fbf9b5b
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .github/workflows/cypress-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,12 @@ jobs:
./
/home/runner/.cache/Cypress
- name: Set up chromium 125 (118 - 124 crash)
id: setup-chrome
uses: browser-actions/setup-chrome@v1
with:
chrome-version: 125

- name: Set up node ${{ needs.init.outputs.nodeVersion }}
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
Expand Down Expand Up @@ -162,9 +168,11 @@ jobs:
- name: Run E2E cypress tests
run: |
echo $BROWSER_PATH
echo '${{ steps.setup-chrome.outputs.chrome-path }}'
cd 'apps/${{ env.APP_NAME }}'
npx wait-on $CYPRESS_baseUrl
npx cypress run --record false --config defaultCommandTimeout=10000,video=false
npx cypress run --record false --browser $BROWSER_PATH --config defaultCommandTimeout=10000,video=false
env:
# https://github.com/cypress-io/github-action/issues/124
COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }}
Expand All @@ -173,6 +181,7 @@ jobs:
npm_package_name: ${{ env.APP_NAME }}
SPLIT: ${{ strategy.job-total }}
SPLIT_INDEX: ${{ strategy.job-index }}
BROWSER_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}


- name: Upload snapshots
Expand Down

0 comments on commit fbf9b5b

Please sign in to comment.