Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement manual sorting #237

Merged
merged 1 commit into from
May 9, 2020
Merged

Implement manual sorting #237

merged 1 commit into from
May 9, 2020

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Jan 27, 2019

This PR implements manual sorting of tasks.
In order to manually sort a task list, select Manually in the sort-order dropdown and drag the tasks to the position you want them at. The sort-order syncs to Reminders on iOS (and probably MacOS, but I can not test this).

manual-order

Please test this feature with this build of the Tasks app containing manual sorting:
tasks.tar.gz

Closes #28.

@nachoparker
Copy link
Member

Is this for calendars? One change that lowers my UX after the port to Vue (great otherwise) is that my main calendar is now at the bottom. It would be nice to be able to drag it to the top on the left sidebar so that we can have our main task-calendar at the top, readily accessible when we open the app.

Thanks!

@raimund-schluessler
Copy link
Member Author

No, this will be for tasks. For sorting calendars, there is a separate issue already #15. Calendars are now sorted alphabetically to have a consistent order. So as a workaround to have your default calendar at the top you could adjust its name accordingly.

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #237 into master will increase coverage by 2.16%.
The diff coverage is 81.01%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   24.66%   26.82%   +2.16%     
==========================================
  Files          48       48              
  Lines        2522     2591      +69     
  Branches      484      502      +18     
==========================================
+ Hits          622      695      +73     
+ Misses       1758     1754       -4     
  Partials      142      142              

@aiomaster
Copy link

Hi,
thanks for the work. I would like to know what is the current state of this. Is there something missing to get basic manual sorting in tasks?
Thanks!

@raimund-schluessler
Copy link
Member Author

raimund-schluessler commented Nov 26, 2019

I would like to know what is the current state of this. Is there something missing to get basic manual sorting in tasks?

Only time to implement it is missing 😉 And there are a lot of features which are more in demand than manual sorting.

@zeroepix
Copy link

What order will you be doing the sorting in?

As I understand it, for outstanding tasks it was: due>priority>start>alphabetically

For those who might read along and not understand, it means if two tasks are due the same day, the priority will be used to order them. If due date and priority are the same, then start will show the order, etc.

With the manual sort, will it override priority and due dates? I'm thinking there will be some usability conflict and I'm curious as to your solution.

@raimund-schluessler
Copy link
Member Author

With the manual sort, will it override priority and due dates? I'm thinking there will be some usability conflict and I'm curious as to your solution.

There will be a new sort-order option "manual" in the dropdown menu. Only when this is selected, the manual sort order will be considered.

@HieronymusCH
Copy link

I second the manual sorting order.

And thank you for your work.
\o/

@kilrau
Copy link

kilrau commented Mar 25, 2020

Keep it up! @raimund-schluessler

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@szaimen
Copy link
Contributor

szaimen commented May 9, 2020

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Sort tasks
7 participants