add compatibility for janus 1.x #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
reviewed
Feb 27, 2024
| PeerConnectionWrapper.this.dataChannel = dataChannel; | ||
| PeerConnectionWrapper.this.dataChannel.registerObserver(new MagicDataChannelObserver()); | ||
| } | ||
| PeerConnectionWrapper.this.dataChannel = dataChannel; |
There was a problem hiding this comment.
Similar to nextcloud/talk-ios#1557 (comment) it probably would make sense to log something if a dataChannel has already been stored.
mahibi
force-pushed
the
bugfix/2704/janus1x
branch
from
99941f6 to
f070d42
Compare
SystemKeeper
approved these changes
Mar 1, 2024
mahibi
force-pushed
the
bugfix/2704/janus1x
branch
from
f070d42 to
f2292b4
Compare
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
bugfix/2704/janus1x
branch
from
f2292b4 to
fcf6c84
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3670-talk.apk |
|
Can you tell me what version the fix will be in? Now the latest release of nextcloud/talk-android is 18.0.1. |
|
@skl256 I just annotated the (future) release version this will be shipped with sicne this pr got merged to the main branch: 19.0.0 scheduled for April |
|
/backport to stable-18.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2704
Ref:
🏁 Checklist
/backport to stable-xx.x