enh: add filtering in views for multi selection #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
enjeck
reviewed
Jan 25, 2024
I am working on it right now. Will add general commands to insert data into the create row modal... |
added 2 commits
January 25, 2024 10:06
- add data-cy to form sections - add general commands to fill in data in forms for selection column - add test cases for all selection types - add basic combination test cases Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
enjeck
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Looks good to me in general, except that most of the selectors are based on class names that are too generic and highly prone to change. There are so many changes, making it a tedious task to replace the selections with "data-cy" attributes. I can help out with replacing them, if you think it's valuable.
enjeck
approved these changes
Jan 29, 2024
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new db structure it is much easier to filter for selection values inside of multi selection columns. This should make this possible to filter for
containsandequal.Not for
emptyfor now. Needs to look into theemptyfilter in general...related to: #648