Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error hints for mandatory fields #755

Merged
merged 5 commits into from
Jan 8, 2024
Merged

feat: add error hints for mandatory fields #755

merged 5 commits into from
Jan 8, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Dec 27, 2023

Addresses #702

@enjeck
Copy link
Contributor Author

enjeck commented Dec 27, 2023

Looks like so:
Screenshot from 2023-12-27 17-54-48

@enjeck enjeck added enhancement New feature or request 2. developing Work in progress labels Dec 27, 2023
@juliushaertl juliushaertl linked an issue Dec 28, 2023 that may be closed by this pull request
Error hints for mandatory fields #702
Closed
@enjeck enjeck force-pushed the feature/702 branch 2 times, most recently from f48c512 to 38a2d19 Compare December 29, 2023 09:27
@juliushaertl
Copy link
Member

A small test case would be nice, but doing it in cypress e2e tests seems a bit overkill and we do not have frontend unit testing or component testing ready in the tables app yet and not sure how well those components are testable with that in its current state, so maybe still just stick to a simple cypress test.

@enjeck enjeck force-pushed the feature/702 branch 2 times, most recently from c04e819 to f1c0679 Compare January 2, 2024 06:33
@juliushaertl juliushaertl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 3, 2024
@enjeck
feat: add error hints for mandatory fields
f34b165 
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck
style: use NcButton instead of button
68451a5 
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck
style: separate placeholder string
c1ec69e 
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck
test: add e2e test for row
3c2d495 
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck
style: fix lint
87c11e0 
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck enjeck merged commit a92bf26 into main Jan 8, 2024
19 checks passed
@enjeck enjeck deleted the feature/702 branch January 8, 2024 03:32
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@datenangebot datenangebot mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@datenangebot datenangebot Awaiting requested review from datenangebot

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error hints for mandatory fields
2 participants
@enjeck @juliushaertl