Make Applications visible by default in the app navigation bar

[blizzz]

Contributes to #1177

In 0.7.* we are displaying Tables Applications by default and without further exposed options by default in the navigation bar. The intended default was hidden, but keeping it would break the experience, and may make them less discoverable in general.

[blizzz]

FWIW it is not really applicable here (table share…), but have the same default may lead to less confusion in the future us's.

[blizzz]

Mh, OpenAPI (not committed yet) has an issue with the constant. Neither does the command deduct the default value, but it also considers it required, instead of optional:

diff --git a/openapi.json b/openapi.json
index 652d6d5c..ea5b1c45 100644
--- a/openapi.json
+++ b/openapi.json
@@ -2439,7 +2439,8 @@
                                     "nodeId",
                                     "nodeType",
                                     "receiver",
-                                    "receiverType"
+                                    "receiverType",
+                                    "displayMode"
                                 ],
                                 "properties": {
                                     "nodeId": {
@@ -2496,7 +2497,6 @@
                                     "displayMode": {
                                         "type": "integer",
                                         "format": "int64",
-                                        "default": 0,
                                         "description": "context shares only, whether it should appear in nav bar. 0: no, 1: recipients, 2: all"
                                     }
                                 }

[blizzz]

Mh, OpenAPI (not committed yet) has an issue with the constant. Neither does the command deduct the default value, but it also considers it required, instead of optional:

diff --git a/openapi.json b/openapi.json
index 652d6d5c..ea5b1c45 100644
--- a/openapi.json
+++ b/openapi.json
@@ -2439,7 +2439,8 @@
                                     "nodeId",
                                     "nodeType",
                                     "receiver",
-                                    "receiverType"
+                                    "receiverType",
+                                    "displayMode"
                                 ],
                                 "properties": {
                                     "nodeId": {
@@ -2496,7 +2497,6 @@
                                     "displayMode": {
                                         "type": "integer",
                                         "format": "int64",
-                                        "default": 0,
                                         "description": "context shares only, whether it should appear in nav bar. 0: no, 1: recipients, 2: all"
                                     }
                                 }

I dug down that hole. In the PHP parser used, we can get the class and the name of the constant, but not its value. Reflection is not an option there. So I changed it back to literal value in the Api1Controller.

UPDATE: @provokateurin confirmed in chat this is the way to go for now.