Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(integration): tests against context updates #1072

Merged
merged 2 commits into from
Jun 5, 2024
Merged

ci(integration): tests against context updates #1072

merged 2 commits into from
Jun 5, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 6, 2024 •
edited
Loading

contributes to #1006 ("Updating Context")

  • includes a fix that ensures the data types and presence of required data in $nodes parameters on Controller level instead. This includes an compatible open API update ("permissions" not required anymore, defaults to READ).

Base automatically changed from enh/1006/integration-tests-delete to main May 6, 2024 20:27
@blizzz blizzz mentioned this pull request May 6, 2024
Closed
48 tasks
@blizzz blizzz force-pushed the enh/1006/integration-context-updates branch from 1f8e8ba to 2d6614a Compare May 17, 2024 12:58
@blizzz blizzz force-pushed the enh/1006/integration-context-updates branch 5 times, most recently from cadd5cc to e475c3f Compare May 30, 2024 17:05
@blizzz blizzz added the 2. developing Work in progress label May 30, 2024
@blizzz blizzz force-pushed the enh/1006/integration-context-updates branch 4 times, most recently from ee72fab to 1c5a886 Compare June 4, 2024 08:46
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 4, 2024
@blizzz blizzz marked this pull request as ready for review June 4, 2024 08:46
@blizzz
Copy link
Member Author

blizzz commented Jun 4, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 4, 2024
blizzz added 2 commits June 4, 2024 11:41
@blizzz
ci(integration): tests against context updates
9e394fb 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix(Contexts): cast incoming node data on controller level
ba50e4b 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/1006/integration-context-updates branch from 1c5a886 to ba50e4b Compare June 4, 2024 09:41
elzody
elzody approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my understanding is sufficient, the tests look okay to me. may also be worth a second opinion :)

@juliusknorr juliusknorr merged commit a710879 into main Jun 5, 2024
57 checks passed
@juliusknorr juliusknorr deleted the enh/1006/integration-context-updates branch June 5, 2024 06:52
@backportbot backportbot bot mentioned this pull request Jun 5, 2024
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@elzody elzody elzody approved these changes

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @juliusknorr @elzody