Skip to content

Commit

Permalink
Fixes small create view bug
Browse files Browse the repository at this point in the history
Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
  • Loading branch information
Hephi2 committed Aug 9, 2023
1 parent b119bec commit e83eba3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 142 deletions.
2 changes: 1 addition & 1 deletion src/modules/main/sections/Table.vue
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default {
},
methods: {
createView() {
emit('tables:view:create', { tableId: this.table.id, viewSetting: this.viewSetting })
emit('tables:view:create', { tableId: this.table.id, viewSetting: this.viewSetting.length > 0 ? this.viewSetting : null })
},
},
}
Expand Down
138 changes: 0 additions & 138 deletions src/modules/modals/CreateView.vue

This file was deleted.

2 changes: 1 addition & 1 deletion src/modules/modals/ViewSettings.vue
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export default {
const success = await this.updateViewToBE(this.mutableView.id)
this.localLoading = false
if (success) {
// await this.$router.push('/view/' + this.mutableView.id).catch(err => err)
if (this.createView) await this.$router.push('/view/' + this.mutableView.id).catch(err => err)
this.actionCancel()
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/shared/components/ncTable/mixins/magicFields.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ export const MagicFields = {
id: 'me',
label: t('tables', 'Me (user ID)'),
icon: 'icon-user',
goodFor: [ColumnTypes.TextLine, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich],
goodFor: [ColumnTypes.TextLine, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich, ColumnTypes.TextLink],
replace: getCurrentUser().uid,
}),
MyName: new MagicField({
id: 'my-name',
label: t('tables', 'Me (name)'),
icon: 'icon-user',
goodFor: [ColumnTypes.TextLine, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich],
goodFor: [ColumnTypes.TextLine, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich, ColumnTypes.TextLink],
replace: getCurrentUser().displayName,
}),
Checked: new MagicField({
Expand Down

0 comments on commit e83eba3

Please sign in to comment.