Fix scrolling on participants list #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Firefox, the participants tab view requires its overflow to be hidden to limit its size to the size of its parents. Otherwise, the participants tab view grows to fit its children; if that happens then no scroll bar is shown for the participants list, as the participants list is tall enough to fit all its items (even if they are not visible because they are in the overflow area). In Chromium, on the other hand, the participants tab view size is always limited by its parents, no matter if the overflow is hidden or not. In a similar way, once the overflow is hidden the bottom padding added to the participants list has to be added to its last item instead. Firefox only takes into account the bottom padding in the participants list when the list has not overflown the participants tab view; it needs to be added to the last item to be taken into account also when the participants list is taller than the participants tab view. Chromium, on the other hand, always takes into account the padding, no matter if it is added to the participants list or to its last item. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
approved these changes
May 11, 2018
|
please backport soon, thanks :) |
|
Soon enough? :-P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #851, which is a regression introduced in #745.
When using Firefox, the participants tab view requires its overflow to be hidden to limit its size to the size of its parents. Otherwise, the participants tab view grows to fit its children; if that happens then no scroll bar is shown for the participants list, as the participants list is tall enough to fit all its items (even if they are not visible because they are in the overflow area). In Chromium, on the other hand, the participants tab view size is always limited by its parents, no matter if the overflow is hidden or not.
In a similar way, once the overflow is hidden the bottom padding added to the participants list has to be added to its last item instead. Firefox only takes into account the bottom padding in the participants list when the list has not overflown the participants tab view; it needs to be added to the last item to be taken into account also when the participants list is taller than the participants tab view. Chromium, on the other hand, always takes into account the padding, no matter if it is added to the participants list or to its last item.