Move loading of chat messages to signaling class. #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes yet, but this will allow later to use the standalone signaling backend to notify clients about new chat messages without having to poll (see #624). Signed-off-by: Joachim Bauch <bauch@struktur.de>
fancycode
added
3. to review
feature: chat 💬
Ivansss
approved these changes
May 29, 2018
Ivansss
approved these changes
Jun 11, 2018
danxuliu
approved these changes
Jun 11, 2018
There was a problem hiding this comment.
Sorry for the delay :-$
Tested and works; code looks good 👍
The only thing that I would change is the name of some members added to the signaling classes (like messagesReceiveStart), as it is unclear whether they refer to chat messages or signaling messages. Anyway, that could be cleaned up in the future ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes yet, but this will allow later to use the standalone signaling backend to notify clients about new chat messages without having to poll (see #624).