Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic status change feature #6110

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

CarlSchwan
Copy link
Member

See for the API in server: nextcloud/server#28403

Signed-off-by: Carl Schwan carl@carlschwan.eu

lib/Status/Listener.php Outdated Show resolved Hide resolved
lib/Status/Listener.php Outdated Show resolved Hide resolved
lib/Status/Listener.php Outdated Show resolved Hide resolved
@jancborchardt
Copy link
Member

So @nickvergessen @CarlSchwan and I had a call and we will do:

  • We use "Away" instead of "Do not disturb" as dnd will prevent any push notifications. This would not be nice if important messages come in or you are in a longer coworking call where you actually are available.
  • As mentioned in the spec: For proper feedback that your status changed, the avatar in the top right of the header should have the status icon/emoji overlay just like it does elsewhere too. This way you are more likely to see that your status has changed and can reset if you like.
  • In the Status modal, between the "What’s your status" input and the 5 suggestions, we put a block like this (with the second line being a text link / button:

Automatically set during calls and events.
Reset to 📅 Vacation next week

The status is of a type "away" with a message that the user is in a
call.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@nickvergessen
Copy link
Member

nickvergessen commented Oct 19, 2021

We use "Away" instead of "Do not disturb" as dnd will prevent any push notifications. This would not be nice if important messages come in or you are in a longer coworking call where you actually are available.

Done

As mentioned in the spec: For proper feedback that your status changed, the avatar in the top right of the header should have the status icon/emoji overlay just like it does elsewhere too. This way you are more likely to see that your status has changed and can reset if you like.

The icon shows fine, but the menu entry seems to not update?

Tab with the call New tab opened after joining the call in Tab 1
Bildschirmfoto von 2021-10-19 09-00-53 Bildschirmfoto von 2021-10-19 09-01-26

It self healed after navigating to another tab and back multiple times. So it's just weird that hte avatar icon and the menu status are not alined for some time. But I guess the avatar is reactive and the menu pulls somehow?

=> nextcloud/server#29313

  • In the Status modal, between the "What’s your status" input and the 5 suggestions, we put a block like this (with the second line being a text link / button:

Automatically set during calls and events.
Reset to 📅 Vacation next week

Still missing, but not related to the Talk change

=> nextcloud/server#29339

Signed-off-by: Joas Schilling <coding@schilljs.com>
lib/Status/Listener.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants