Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChatView): adjust dragover position #14264

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix(ChatView): adjust dragover position #14264

merged 1 commit into from
Jan 31, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 31, 2025 •
edited
Loading

☑️ Resolves

Regression from #14237

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Jan 31, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy January 31, 2025 10:15
@DorraJaouad DorraJaouad self-assigned this Jan 31, 2025
@DorraJaouad
fix(ChatView): adjust .messages-list-dragover-wrapper styles so new m…
a06f5f4 
…essage input can expand

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/chat-view-styles branch from 63e04b7 to a06f5f4 Compare January 31, 2025 11:19
Antreesy
Antreesy approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems to fix the problem

@DorraJaouad DorraJaouad merged commit 765a058 into main Jan 31, 2025
53 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/chat-view-styles branch January 31, 2025 11:25
@DorraJaouad
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @Antreesy