Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversations): compact view #14099

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 10, 2025

☑️ Resolves

REMARK: avatar size was explicitly chosen 20px to match the appearance of settings LS, but we can make it EXTRA_SMALL (22px)

  • Call and Favorite icons are 15px
  • Status icon is reduced to 11px

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Normal Compact

🚧 Tasks

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad changed the title feat(conversations): add backend support of compact list feat(conversations): compact view Jan 10, 2025
@DorraJaouad DorraJaouad force-pushed the feat/11697/compact-list-api branch from 3e4057c to 015902a Compare January 10, 2025 12:41
@DorraJaouad DorraJaouad requested a review from Antreesy January 10, 2025 12:50
@DorraJaouad DorraJaouad force-pushed the feat/11697/compact-list-ui branch from c6b43b3 to 64a210a Compare January 10, 2025 12:52
@Antreesy Antreesy force-pushed the feat/11697/compact-list-api branch from 015902a to 3f35371 Compare January 10, 2025 12:55
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Jan 10, 2025
Base automatically changed from feat/11697/compact-list-api to main January 10, 2025 13:05
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/11697/compact-list-ui branch from 64a210a to 2647b89 Compare January 10, 2025 13:35
@DorraJaouad DorraJaouad marked this pull request as ready for review January 10, 2025 13:36
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge-able

@nickvergessen nickvergessen merged commit f441b4a into main Jan 10, 2025
51 of 52 checks passed
@nickvergessen nickvergessen deleted the feat/11697/compact-list-ui branch January 10, 2025 14:56
src/components/ConversationIcon.vue Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Show resolved Hide resolved
@@ -300,6 +300,7 @@ export const BOT = {

export const AVATAR = {
SIZE: {
COMPACT: 20,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24, as the height of .list-item-content?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.list-item-content is 20. Yet, I can see your point that the icon looks smaller than the icon in the settings left sidebar.

@DorraJaouad DorraJaouad mentioned this pull request Jan 12, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversations list compact mode
3 participants