-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TopBar): add next meeting date #12902
Conversation
bac8c7d
to
1fbbb94
Compare
Something missing? |
The url parameter to calendar from API. Will test today (Done) |
👍 Tested and works 👏 I noticed a bug with full day events. The start time is relative to UTC, so full day events show at 2AM for events in CEST. I'll try to fix thin in the API. |
1fbbb94
to
eacbd39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good design-wise, just see my 2 inline comments on semantics. :)
</div> | ||
<div class="event-info"> | ||
<p class="event-info__header"> | ||
{{ t('spreed', 'Next call') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it say next meeting or call?
Could be an arranged chat session as well? cant really judge from the event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, all of them are a call but the topic differs ( meeting, session...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this was about the cases people are not really initiating a video/audio call.
But that really depends on the definition of call
:
- an order or request for someone to be present 📆
- an instance of speaking to someone on the phone 🤙🏽
- a brief visit 👀
I find Next call
appropriate, but we can also consider Next event
, Next meeting
, or leave the note to translators what this is about, to represent correctly on another languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Next call" is nice cause the button next to it says "Start call" so the language is the same.
But e.g. if we have a Talk conversation for the conference and the conference event is linked to that, it’s just "Next event". So that would be more generically applicable, to cover all sorts of cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knowing f a conversation was made for a conference or conference-like event is a bit tricky from info given in hand. Yet, We can use "Next event" if :
- Conversation is a public conversation
OR - Conversation has more than 50 participants (cannot be a team room)
OR - the meeting is full day (cannot be a meeting or a call)
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
4688013
to
cba69ad
Compare
/backport to stable30 |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist