Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(public share): make trigger button color contrast to background #12825

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix(public share): make trigger button color contrast to background #12825

merged 1 commit into from
Jul 27, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
☀️ Light theme 🌑 Dark Theme
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Jul 26, 2024
@Antreesy Antreesy requested review from susnux and ShGKme July 26, 2024 16:37
@Antreesy Antreesy self-assigned this Jul 26, 2024
@Antreesy
fix(public): make trigger button color contrast to background
f33c2c2 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12132/public-share-trigger branch from bd57816 to f33c2c2 Compare July 27, 2024 15:12
@Antreesy Antreesy enabled auto-merge July 27, 2024 15:14
@Antreesy Antreesy merged commit e6704ad into main Jul 27, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12132/public-share-trigger branch July 27, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

polishing of sidebar in public view
3 participants
@Antreesy @susnux @ShGKme