[stable28] fix(sidebar): use open state to remove always working focus trap on mobile #12693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
3. to review
bug
feature: frontend 🖌️
ShGKme
changed the title
ShGKme
force-pushed
the
backport/12610/stable28
branch
from
f3bb0ff to
6e61a18
Compare
ShGKme
approved these changes
Oct 10, 2024
ShGKme
force-pushed
the
backport/12610/stable28
branch
2 times, most recently
from
c3b87e3 to
ede4afe
Compare
|
Best merge together with |
|
Apparently this needs a vue lib bump which we don't do for this release, so lets check in the november release |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
backport/12610/stable28
branch
from
ede4afe to
736b884
Compare
|
Rebased, resolved conflict. |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12610
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.