Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Send disinvite on remote user removal and remove invite #11464

Merged

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Send disinvite
  • Ensure the remote user is no longer in the/a room and does not have an invite anymore

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Jan 26, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Jan 26, 2024
@nickvergessen nickvergessen self-assigned this Jan 26, 2024
Base automatically changed from feat/11278/add-room-to-response-when-accepting-invite to main January 29, 2024 08:38
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/5723/send-disinvite-when-removing-remote-user branch from 0fca857 to b3bdf65 Compare January 29, 2024 11:05
@Antreesy
Copy link
Contributor

Couple of things I've noticed:

Should disinvite dismiss not accepted notifications with invite?
image

For accepted users, disinvite just removes them from the room on remote server. Could we send a notification as well (admin has unshared a room with you) to handle it on the frontend and leave the federated room on local server?

@nickvergessen
Copy link
Member Author

Should disinvite dismiss not accepted notifications with invite?

It should, fixing this now

For accepted users, disinvite just removes them from the room on remote server. Could we send a notification as well (admin has unshared a room with you) to handle it on the frontend and leave the federated room on local server?

We should not send a (push) notification, but we should trigger a signaling message for the user I guess?

… correctly

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Something weird was on my local dev, but now it works fine. Removing of participant from both rooms is processed correctly

@nickvergessen nickvergessen merged commit bc0d861 into main Jan 29, 2024
53 checks passed
@nickvergessen nickvergessen deleted the bugfix/5723/send-disinvite-when-removing-remote-user branch January 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants