Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add net interface resource object #411

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Feat/add net interface resource object #411

merged 1 commit into from
Jan 24, 2023

Conversation

kesselb
Copy link
Collaborator

@kesselb kesselb commented Dec 30, 2022 •
edited
Loading

Close #168

@kesselb kesselb self-assigned this Dec 30, 2022
@kesselb kesselb linked an issue Jan 4, 2023 that may be closed by this pull request
PHP error Invalid argument supplied for foreach() #168
Closed
@kesselb kesselb force-pushed the feat/add-net-interface-resource-object branch 2 times, most recently from 857c4b6 to 0910f0d Compare January 10, 2023 22:37
@kesselb kesselb marked this pull request as ready for review January 10, 2023 22:37
@kesselb kesselb force-pushed the feat/add-net-interface-resource-object branch 2 times, most recently from 6cfa887 to 35c0c25 Compare January 10, 2023 22:59
@kesselb kesselb added this to the Nextcloud 26 milestone Jan 15, 2023
@szaimen
Copy link
Contributor

szaimen commented Jan 15, 2023

Sorry, I don't feel able to review this :/

@kesselb
Copy link
Collaborator Author

kesselb commented Jan 15, 2023

Sorry, I don't feel able to review this :/

No problem ;)

@kesselb kesselb requested review from come-nc and removed request for szaimen January 15, 2023 22:24
@kesselb kesselb mentioned this pull request Jan 15, 2023
Closed
come-nc
come-nc reviewed Jan 16, 2023
View reviewed changes
lib/OperatingSystems/DefaultOs.php Outdated Show resolved Hide resolved
lib/OperatingSystems/DefaultOs.php Show resolved Hide resolved
tests/lib/DefaultOsTest.php Outdated Show resolved Hide resolved
tests/lib/FreeBSDTest.php Show resolved Hide resolved
st3iny
st3iny approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far and works. Did you test in on FreeBSD?

lib/Resources/NetInterface.php Outdated Show resolved Hide resolved
@kesselb
Copy link
Collaborator Author

kesselb commented Jan 20, 2023

Did you test in on FreeBSD?

Not really.
I run php -r "var_export(net_get_interfaces());" to check if net_get_interfaces is available and capture the data for the tests on a virtual FreeBSD machine.

@kesselb kesselb force-pushed the feat/add-net-interface-resource-object branch from eb6e51b to 8e53e52 Compare January 20, 2023 22:06
@kesselb kesselb force-pushed the feat/add-net-interface-resource-object branch from 8e53e52 to 6de1d37 Compare January 23, 2023 21:05
@kesselb kesselb force-pushed the feat/add-net-interface-resource-object branch from 6de1d37 to b23548b Compare January 23, 2023 21:17
@kesselb
feat: use net_get_interfaces to read network adapter
9b842b9 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the feat/add-net-interface-resource-object branch from b23548b to 9b842b9 Compare January 23, 2023 21:20
@kesselb kesselb merged commit c191baa into master Jan 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/add-net-interface-resource-object branch January 24, 2023 08:57
@kesselb kesselb mentioned this pull request Jan 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@come-nc come-nc come-nc approved these changes

@KDederichs KDederichs Awaiting requested review from KDederichs

@J0WI J0WI Awaiting requested review from J0WI

Assignees

@kesselb kesselb

Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

PHP error Invalid argument supplied for foreach()
4 participants
@kesselb @szaimen @st3iny @come-nc