-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated URL functions for OCP\Util #8811
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,33 +233,6 @@ public static function linkToPublic($service) { | |
return \OC_Helper::linkToPublic($service); | ||
} | ||
|
||
/** | ||
* Creates an url using a defined route | ||
* @param string $route | ||
* @param array $parameters | ||
* @internal param array $args with param=>value, will be appended to the returned url | ||
* @return string the url | ||
* @deprecated 8.1.0 Use \OC::$server->getURLGenerator()->linkToRoute($route, $parameters) | ||
* @since 5.0.0 | ||
*/ | ||
public static function linkToRoute( $route, $parameters = array() ) { | ||
return \OC::$server->getURLGenerator()->linkToRoute($route, $parameters); | ||
} | ||
|
||
/** | ||
* Creates an url to the given app and file | ||
* @param string $app app | ||
* @param string $file file | ||
* @param array $args array with param=>value, will be appended to the returned url | ||
* The value of $args will be urlencoded | ||
* @return string the url | ||
* @deprecated 8.1.0 Use \OC::$server->getURLGenerator()->linkTo($app, $file, $args) | ||
* @since 4.0.0 - parameter $args was added in 4.5.0 | ||
*/ | ||
public static function linkTo( $app, $file, $args = array() ) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
return \OC::$server->getURLGenerator()->linkTo($app, $file, $args); | ||
} | ||
|
||
/** | ||
* Returns the server host name without an eventual port number | ||
* @return string the server hostname | ||
|
@@ -307,18 +280,6 @@ public static function getDefaultEmailAddress($user_part) { | |
return $user_part.'@localhost.localdomain'; | ||
} | ||
|
||
/** | ||
* Creates path to an image | ||
* @param string $app app | ||
* @param string $image image name | ||
* @return string the url | ||
* @deprecated 8.1.0 Use \OC::$server->getURLGenerator()->imagePath($app, $image) | ||
* @since 4.0.0 | ||
*/ | ||
public static function imagePath( $app, $image ) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
return \OC::$server->getURLGenerator()->imagePath($app, $image); | ||
} | ||
|
||
/** | ||
* Make a human file size (2048 to 2 kB) | ||
* @param int $bytes file size in bytes | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used by those apps: