Fix unit tests for CalendarManager #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzer
approved these changes
Dec 12, 2017
|
It's used here to connect the dav app to the server's calendar API: |
georgehrke
approved these changes
Dec 12, 2017
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beside that:
@georgehrke Where is this actually used? Because I only see that
CalendarManageris mapped in the server container to\OC\Calendar\Managerinstead - could it be that this one is not used anymore (or vice versa)?ref #6840 (where it was introduced) and #6884 (which was merged without a failure and then suddenly master had problems)