Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add postgresql 10 compatibility to dbal #7210

Merged
merged 3 commits into from
Nov 27, 2017
Merged

add postgresql 10 compatibility to dbal #7210

merged 3 commits into from
Nov 27, 2017

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 17, 2017

Update doctrine/dbal to include doctrine/dbal#2893 and doctrine/dbal#2916 to make it work with postgresql 10

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 17, 2017
@icewind1991 icewind1991 added this to the Nextcloud 13 milestone Nov 17, 2017
@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #7210 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7210      +/-   ##
============================================
+ Coverage     50.84%   50.87%   +0.02%     
+ Complexity    24548    24534      -14     
============================================
  Files          1585     1584       -1     
  Lines         93804    93770      -34     
  Branches       1354     1356       +2     
============================================
+ Hits          47693    47703      +10     
+ Misses        46111    46067      -44
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 58.97% <ø> (+0.94%) 23 <0> (-1) ⬇️
lib/private/Security/Bruteforce/Throttler.php 38.13% <0%> (-5.14%) 27% <0%> (+2%)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Server.php 82.74% <0%> (-0.46%) 126% <0%> (ø)
lib/private/legacy/image.php 38.51% <0%> (-0.4%) 208% <0%> (-4%)
apps/comments/js/commentstabview.js 80.06% <0%> (-0.27%) 0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/legacy/app.php 54.06% <0%> (-0.12%) 221% <0%> (ø)
lib/private/Share20/Manager.php 86.55% <0%> (-0.1%) 235% <0%> (+1%)
lib/private/legacy/util.php 58.68% <0%> (-0.03%) 224% <0%> (-1%)
... and 20 more

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a drone job for postgres10 so we actually know it works ;)

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

@rullzer done

@MorrisJobke
Copy link
Member

Please update 3rdparty to contain current master.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Updated the thirdparty ref. Let's see what CI says :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants