Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move actions of sharing link to popover menu #7010

Closed
wants to merge 2 commits into from

Conversation

jancborchardt
Copy link
Member

Moving the actions (editability, password protection) to the 3-dot-menu which is shown to the right of the share link input.

TODO and where I need help from @nextcloud/javascript @blizzz @MorrisJobke @danxuliu

  • Make the actions actually show up in the menu
  • Move expiration date to that menu also
  • When enabling »Share link«, also open the 3-dot-menu automatically so people see the settings
  • (Ideally also automatically copy the link to the clipboard and give feedback about it via tooltip)

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@MorrisJobke
Copy link
Member

Maybe @skjnldsv or @danxuliu want to look into this?

@MorrisJobke
Copy link
Member

I would say we should better spend our time on #5336 and then this will be automatically be the case. Otherwise there was no activity since over half a year. Let's close it then and we can reopen anytime once this turns out to be the way to go.

@MorrisJobke MorrisJobke deleted the sharing-link branch May 23, 2018 16:36
@MorrisJobke MorrisJobke removed this from the Nextcloud 14 milestone May 23, 2018
@jancborchardt jancborchardt restored the sharing-link branch May 28, 2018 14:20
@jancborchardt
Copy link
Member Author

@MorrisJobke this is actually intended to be a first step towards implementation of #5336, and it’s still the way to go. I wouldn’t close it hence, but it would be nice if some @nextcloud/javascript folks could have a look at it. :)

@jancborchardt jancborchardt reopened this May 28, 2018
@codecov
Copy link

codecov bot commented May 28, 2018

Codecov Report

Merging #7010 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7010      +/-   ##
============================================
- Coverage     52.76%   52.52%   -0.25%     
  Complexity    22802    22802              
============================================
  Files          1442     1381      -61     
  Lines         88563    80950    -7613     
  Branches       1349        0    -1349     
============================================
- Hits          46729    42517    -4212     
+ Misses        41834    38433    -3401
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Local.php 76.49% <0%> (-2.18%) 86% <0%> (ø)
core/js/public/appconfig.js
core/js/files/client.js
apps/files_sharing/js/files_drop.js
core/js/mimetype.js
settings/js/apps.js
apps/files_external/js/statusmanager.js
apps/files_external/js/mountsfilelist.js
apps/files_sharing/js/sharebreadcrumbview.js
core/js/share.js
... and 51 more

@MorrisJobke MorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@MorrisJobke
Copy link
Member

This is now the case:

bildschirmfoto 2018-07-25 um 16 22 10

Was fixed by #10218

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 25, 2018
@MorrisJobke MorrisJobke deleted the sharing-link branch July 25, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants