Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(S3): add SSE-C support in S3 External Storage #50514

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat(S3): add SSE-C support in S3 External Storage #50514

merged 2 commits into from
Jan 29, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 28, 2025 •
edited
Loading

Summary

Adds missing bits to support SSE-C in S3 external storage.

Just need to add the parameter and fix two calls. All other logic is already implemented and implicitly called through the S3ConnectionTrait

Documentation PR: nextcloud/documentation#12530

Checklist

before:
Screenshot 2025-01-22 at 23 50 41

after:
Screenshot 2025-01-22 at 23 49 44

lobeck and others added 2 commits January 28, 2025 22:57
@lobeck @st3iny
feat(S3): add SSE-C support in S3 External Storage
c25c5bb 
Just need to add the parameter and fix two calls. All other logic is already implemented and implicitly called through the S3ConnectionTrait

fixes #33283

Signed-off-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny @lobeck
fix(s3): treat empty sse_c_key as not set
f1c025d 
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny requested review from artonge and come-nc January 28, 2025 22:01
@st3iny st3iny self-assigned this Jan 28, 2025
@st3iny st3iny mentioned this pull request Jan 28, 2025
Closed
4 tasks
@st3iny
Copy link
Member Author

st3iny commented Jan 28, 2025

/backport f1c025d to stable31

@st3iny
Copy link
Member Author

st3iny commented Jan 28, 2025

/backport f1c025d to stable30

@st3iny
Copy link
Member Author

st3iny commented Jan 28, 2025

/backport f1c025d to stable29

@st3iny st3iny requested a review from juliusknorr January 28, 2025 22:03
@st3iny st3iny mentioned this pull request Jan 28, 2025
Closed
4 tasks
@st3iny st3iny added this to the Nextcloud 32 milestone Jan 28, 2025
@AndyScherzinger AndyScherzinger merged commit 3f45bc5 into master Jan 29, 2025
192 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/s3/sse-c branch January 29, 2025 17:32
This was referenced Jan 29, 2025
Merged
Merged
Merged
@st3iny st3iny mentioned this pull request Jan 31, 2025
Closed
@st3iny
Copy link
Member Author

st3iny commented Jan 31, 2025

/backport c25c5bb to stable31

@backportbot backportbot bot mentioned this pull request Jan 31, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge artonge approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews feature: external storage feature: object storage
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

SSE-C support in S3 via External Storage
5 participants
@st3iny @juliusknorr @artonge @AndyScherzinger @lobeck