Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occ): hide sensitive data while config:app:set #50426

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jan 25, 2025

local repo copy of approved PR #49826

Closes #49826


Summary

Do not display sensitive values in CLI output.

Before:

./occ config:app:set --value "secret!" --sensitive --type string my_app my_secret_pass        

⚠️ my pass is visible in output as plain text

Config value 'my_secret_pass' for app 'my_app' is now set to 'secret!', stored as string in fast cache

After:

./occ config:app:set --value "secret!" --sensitive --type string my_app my_secret_pass             

☑️ my pass is displayed as <sensitive>

Config value 'my_secret_pass' for app 'my_app' is now set to '<sensitive>', stored as string in fast cache

Checklist

in order to hide sensitive data from logs

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@AndyScherzinger AndyScherzinger added enhancement 4. to release Ready to be released and/or waiting for tests to finish feature: occ labels Jan 25, 2025
@AndyScherzinger
Copy link
Member Author

/backport to stable31

@AndyScherzinger AndyScherzinger merged commit 77315cb into master Jan 25, 2025
189 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/49826/occ_hide_sensitive_values branch January 25, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: occ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants