Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Public WebDAV endpoint should allow GET requests #48628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dav): Public WebDAV endpoint should allow GET requests #48628

wants to merge 1 commit into from
+127 −12

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 9, 2024 •
edited
Loading

Summary

GET should be allowed even without Ajax header to allow downloading files, or show files in the viewer. All other requests could be guarded, but this should not.

I think this was copy-paste from the v1 implementation, but that did not provide GET support, so for the old endpoint it made sense. But now with GET support we need to allow browsers to access the files without custom headers.

Checklist

@susnux susnux requested review from skjnldsv, a team, ArtificialOwl and artonge and removed request for a team October 9, 2024 11:55
@susnux susnux added this to the Nextcloud 31 milestone Oct 9, 2024
@susnux
Copy link
Contributor Author

susnux commented Oct 9, 2024

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Oct 9, 2024

/backport to stable29

provokateurin
provokateurin approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@susnux
fix(dav): Public WebDAV endpoint should allow GET requests
bbc5d32 
`GET` should be allowed even without Ajax header to allow downloading files,
or show files in the viewer. All other requests could be guarded, but this should not.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request bug feature: dav
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Viewing media files via a share link doesn't work anymore
3 participants
@susnux @provokateurin @sorbaugh