-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Vue app names #48536
base: master
Are you sure you want to change the base?
fix: Vue app names #48536
Conversation
d95679d
to
44eadf2
Compare
44eadf2
to
ce220c7
Compare
This improves the debugging experience in the vue dev tool. Signed-off-by: Louis Chemineau <louis@chmn.me>
ce220c7
to
812e876
Compare
@@ -225,6 +227,10 @@ export default defineComponent({ | |||
return label | |||
}, | |||
versionHumanExplicitDate(): string { | |||
return useFormatDateTime(this.version.mtime, { relativeTime: false, format: { dateStyle: 'long', timeStyle: 'medium' } }).formattedTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe composables should only be called in setup() 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe composables should only be called in setup() 🙈
Yes, this might work but is not guaranteed as some calls might require setup-context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add:
setup(props) {
const mTime = computed(() => props.version.mtime)
const { formattedTime: versionHumanExplicitDate } = useFormatDateTime(mTime, { relativeTime: false, format: { dateStyle: 'long', timeStyle: 'medium' } })
return {
versionHumanExplicitDate,
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So not really usable in our case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to moment
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
812e876
to
4f356f4
Compare
NcSelect
inNcSharingInput
NcListItem
inVersion
. Will need usage ofactions-aria-label
(https://github.com/nextcloud-libraries/nextcloud-vue/pull/6128/files)