Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: Do not try to set HTTP response code on already closed connection #47980

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 14, 2024

Backport of PR #47971

This avoids a PHP warning in the logs about trying to set the response
 code while the output already started. It’s useless to try to print an
 error page anyway in this situation because the connection was closed
 already.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Sep 14, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.8 milestone Sep 14, 2024
@solracsf solracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 15, 2024
@come-nc come-nc merged commit 9b4637b into stable29 Sep 15, 2024
177 checks passed
@come-nc come-nc deleted the backport/47971/stable29 branch September 15, 2024 07:45
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants