fix: logging done at the beginning and end of getUsersDetails, getUserData and fillStorageInfo #47660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rData and fillStorageInfo
susnux
reviewed
Aug 31, 2024
| @@ -110,6 +110,13 @@ public function __construct(string $appName, | |||
| * @throws OCSNotFoundException | |||
| */ | |||
| protected function getUserData(string $userId, bool $includeScopes = false): ?array { | |||
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |
| \OCP\Server::get(\Psr\Log\LoggerInterface::class)->error( |
There was a problem hiding this comment.
Hi @susnux, This is a draft pr to help us understand why the user list is slow. Hence not merging the same
There was a problem hiding this comment.
No problem, it just was set to ´3 to review` so I gave it a quick look :)
| @@ -222,6 +229,13 @@ protected function getUserData(string $userId, bool $includeScopes = false): ?ar | |||
| 'setDisplayName' => $backend instanceof ISetDisplayNameBackend || $backend->implementsActions(Backend::SET_DISPLAYNAME), | |||
| 'setPassword' => $backend instanceof ISetPasswordBackend || $backend->implementsActions(Backend::SET_PASSWORD), | |||
| ]; | |||
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |
| \OCP\Server::get(\Psr\Log\LoggerInterface::class)->error( |
| @@ -256,6 +270,14 @@ protected function getUserSubAdminGroupsData(string $userId): array { | |||
| * @throws OCSException | |||
| */ | |||
| protected function fillStorageInfo(string $userId): array { | |||
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |
| \OCP\Server::get(\Psr\Log\LoggerInterface::class)->error( |
| @@ -294,6 +316,14 @@ protected function fillStorageInfo(string $userId): array { | |||
| \OC_Util::tearDownFS(); | |||
| return []; | |||
| } | |||
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |
| \OCP\Server::get(\Psr\Log\LoggerInterface::class)->error( |
| @@ -215,6 +215,13 @@ public function getUsersDetails(string $search = '', int $limit = null, int $off | |||
| $usersDetails = []; | |||
| foreach ($users as $userId) { | |||
| $userId = (string) $userId; | |||
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |
| \OCP\Server::get(\Psr\Log\LoggerInterface::class)->error( |
| @@ -231,6 +238,13 @@ public function getUsersDetails(string $search = '', int $limit = null, int $off | |||
| // only showing its id | |||
| $usersDetails[$userId] = ['id' => $userId]; | |||
| } | |||
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(\Psr\Log\LoggerInterface::class)->error( | |
| \OCP\Server::get(\Psr\Log\LoggerInterface::class)->error( |
…rData and fillStorageInfo
susnux
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: logging done at the beginning and end of getUsersDetails, getUserData and fillStorageInfo
Summary
TODO
Checklist