Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UnifiedSearch): Restore normal dialog size #47628

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix(UnifiedSearch): Restore normal dialog size #47628

merged 2 commits into from
Aug 30, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Aug 30, 2024

Before After
Screenshot from 2024-08-30 10-10-14 Screenshot from 2024-08-30 10-07-34

@nfebe
fix(UnifiedSearch): Restore normal dialog size
18d0f39 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe enabled auto-merge August 30, 2024 09:28
@nfebe
Copy link
Contributor Author

nfebe commented Aug 30, 2024

/backport to stable30

@nfebe
Copy link
Contributor Author

nfebe commented Aug 30, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented Aug 30, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
c2d7012 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
susnux approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

core/src/components/UnifiedSearch/UnifiedSearchModal.vue Show resolved Hide resolved
@nfebe nfebe merged commit e076e67 into master Aug 30, 2024
116 checks passed
@nfebe nfebe deleted the fix/restore-unified-search-modal-size branch August 30, 2024 15:17
This was referenced Aug 30, 2024
Closed
Merged
jancborchardt
jancborchardt approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks @fenn-cs!

@AndyScherzinger AndyScherzinger added this to the Nextcloud 31 milestone Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
feature: search feedback-requested
Projects
📁 Files team
Status: 🏗️ In progress
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
7 participants
@nfebe @jancborchardt @susnux @marcoambrosini @sorbaugh @AndyScherzinger @nextcloud-command