Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust filename validation messages #47546

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 27, 2024

Summary

Adjust error messages to be consistent with clients.

Checklist

@susnux susnux requested review from a team, Altahrim, Fenn-CS, provokateurin and alperozturk96 and removed request for a team August 27, 2024 17:43
@susnux susnux added this to the Nextcloud 31 milestone Aug 27, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 27, 2024

/backport to stable30

@susnux susnux force-pushed the fix/files-view-error-messages branch from 371af65 to c49fbf6 Compare August 27, 2024 17:45
@susnux susnux removed the request for review from alperozturk96 August 27, 2024 17:46
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/files-view-error-messages branch from c49fbf6 to 81c6c24 Compare August 27, 2024 21:12
@AndyScherzinger AndyScherzinger merged commit bfb5835 into master Aug 29, 2024
169 of 171 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/files-view-error-messages branch August 29, 2024 21:28
Copy link

backportbot bot commented Aug 29, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47546/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 81c6c24c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47546/stable30

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
dist/3794-3794.js.map.license
dist/4546-4546.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
dist/583-583.js.map.license
dist/9972-9972.js.map.license
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzinger
Copy link
Member

Since I am AFK, could you please do a manual backport @susnux? Thanks 🙏

@skjnldsv
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Error Message Clarity When Moving or Copying Files to Invalid Folders
5 participants