Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix: try to find non-recursive share source #47279

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 16, 2024

Backport of #46881

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews high labels Aug 16, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.9 milestone Aug 16, 2024
instead of always picking the first one, try to find one that won't blow up

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the backport/46881/stable28 branch from 152907e to 0571aa1 Compare August 16, 2024 14:37
@icewind1991 icewind1991 marked this pull request as ready for review August 16, 2024 14:37
$this->cache = null;
break;
}
if (!$this->nonMaskedStorage) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Operand of type false is always falsy
$this->cache = null;
break;
}
if (!$this->nonMaskedStorage) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Docblock-defined type OCP\Files\Storage\IStorage for $this->nonMaskedStorage is never falsy
@sorbaugh sorbaugh merged commit 9f1c6d7 into stable28 Aug 19, 2024
58 of 59 checks passed
@sorbaugh sorbaugh deleted the backport/46881/stable28 branch August 19, 2024 16:27
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants