Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] Apply group limit on remove from group #47192

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 13, 2024

Backport of #47180

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Aug 13, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Aug 13, 2024
artonge and others added 6 commits August 13, 2024 14:32
… from a group

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the backport/47180/stable29 branch from cf4c372 to 3ec0998 Compare August 13, 2024 12:39
@come-nc come-nc marked this pull request as ready for review August 13, 2024 12:40
@come-nc
Copy link
Contributor

come-nc commented Aug 13, 2024

/backport to stable28

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor

come-nc commented Aug 13, 2024

cypress failure is related I think

  Running:  files_sharing/limit_to_same_group.cy.ts                                         (3 of 6)
353

354

355
  Limit to sharing to people in the same group
356
    1) "before all" hook for "Alice can see the shared file"
357

358

359
  0 passing (23s)
360
  1 failing
361

362
  1) Limit to sharing to people in the same group
363
       "before all" hook for "Alice can see the shared file":
364
     CypressError: `cy.request()` failed on:
365

366
http://172.17.0.2/index.php/apps/files
367

368
The response we received from your web server was:
369

370
  > 401: Unauthorized
371

372
This was considered a failure because the status code was not `2xx` or `3xx`.
373

374
If you do not want status codes to cause failures pass the option: `failOnStatusCode: false`

@come-nc
Copy link
Contributor

come-nc commented Aug 13, 2024

/backport to stable28

@come-nc
Copy link
Contributor

come-nc commented Aug 13, 2024

But the node failure I do not understand 🤔

@come-nc
Copy link
Contributor

come-nc commented Aug 13, 2024

cypress failure is related I think

  Running:  files_sharing/limit_to_same_group.cy.ts                                         (3 of 6)
353

354

355
  Limit to sharing to people in the same group
356
    1) "before all" hook for "Alice can see the shared file"
357

358

359
  0 passing (23s)
360
  1 failing
361

362
  1) Limit to sharing to people in the same group
363
       "before all" hook for "Alice can see the shared file":
364
     CypressError: `cy.request()` failed on:
365

366
http://172.17.0.2/index.php/apps/files
367

368
The response we received from your web server was:
369

370
  > 401: Unauthorized
371

372
This was considered a failure because the status code was not `2xx` or `3xx`.
373

374
If you do not want status codes to cause failures pass the option: `failOnStatusCode: false`

Maybe only flaky, it seems to pass now? (runner 2 still failed but on another test, files_sharing/limit_to_same_group.cy.ts passed.

@come-nc
Copy link
Contributor

come-nc commented Aug 13, 2024

It was a flaky test, it’s now passing.
So, once the node issue is fixed (in stable29 as it’s failing there too), this can be merged and backported further.

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 13, 2024
@skjnldsv skjnldsv merged commit aa7f5ac into stable29 Aug 14, 2024
174 of 177 checks passed
@skjnldsv skjnldsv deleted the backport/47180/stable29 branch August 14, 2024 09:39
@skjnldsv
Copy link
Member

Manually approved and merged in RC1.
Discussed with team lead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants