Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Add messages when "new folder" fails or gets cancelled #47181

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix(files): Add messages when "new folder" fails or gets cancelled #47181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58acf4c
fix(files): Add messages when "new folder" fails or gets cancelled
susnux Aug 12, 2024
7be3a9c
chore(assets): Recompile assets
nextcloud-command Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions apps/files/src/newMenu/newFolder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { basename } from 'path'
import { emit } from '@nextcloud/event-bus'
import { getCurrentUser } from '@nextcloud/auth'
import { Permission, Folder } from '@nextcloud/files'
import { showSuccess } from '@nextcloud/dialogs'
import { showError, showInfo, showSuccess } from '@nextcloud/dialogs'
import { translate as t } from '@nextcloud/l10n'
import axios from '@nextcloud/axios'

Expand Down Expand Up @@ -47,7 +47,11 @@ export const entry = {
order: 0,
async handler(context: Folder, content: Node[]) {
const name = await newNodeName(t('files', 'New folder'), content)
if (name !== null) {
if (name === null) {
showInfo(t('files', 'Creating new folder cancelled'))
return
}
try {
const { fileid, source } = await createNewFolder(context, name.trim())

// Create the folder in the store
Expand All @@ -74,9 +78,12 @@ export const entry = {
// Navigate to the new folder
window.OCP.Files.Router.goToRoute(
null, // use default route
{ view: 'files', fileid: folder.fileid },
{ view: 'files', fileid: String(fileid) },
{ dir: context.path },
)
} catch (error) {
logger.error('Creating new folder failed', { error })
showError('Creating new folder failed')
}
},
} as Entry
Loading