fix(systemtags): Sub folders should be opened in files #47135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/open-tags-in-folder
branch
from
cdc5baf to
430625e
Compare
skjnldsv
approved these changes
Aug 8, 2024
| import { type Node, FileType, FileAction, DefaultType } from '@nextcloud/files' | ||
|
|
||
| export const action = new FileAction({ | ||
| id: 'systemtags:open-in-files', |
There was a problem hiding this comment.
This bother me more than it should 😅😅
AndyScherzinger
approved these changes
Aug 8, 2024
Merged
Currently this is simply broken and here are two ways: 1. Open subfolders in files view 2. Implement logic to save last request 1 is the way this is now implemented, basically copy-paste from the recent view. 2 is much more complicated because if we get `/2/foo/bar` as the path we need to know the source of `foo`, so we would need at least 2 requests or cache the previous directory. We do not do it like this for any view so lets just stick with 1 for now. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/open-tags-in-folder
branch
from
d871154 to
124288f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently this is simply broken and here are two ways:
1 is the way this is now implemented, basically copy-paste from the recent view. 2 is much more complicated because if we get
/2/foo/baras the path we need to know the source offoo, so we would need at least 2 requests or cache the previous directory. We do not do it like this for any view so lets just stick with 1 for now.Checklist