-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theming): make cache buster depend on the app version #47095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
juliusknorr
reviewed
Aug 7, 2024
AndyScherzinger
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
AndyScherzinger
added
high
feature: caching
Related to our caching system: scssCacher, jsCombiner...
labels
Aug 7, 2024
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/theming/cache-buster-on-upgrade
branch
from
August 7, 2024 07:48
8596b91
to
087f748
Compare
st3iny
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Aug 7, 2024
/backport to stable28 |
/backport to stable29 |
juliusknorr
approved these changes
Aug 7, 2024
szaimen
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
feature: caching
Related to our caching system: scssCacher, jsCombiner...
feature: theming
high
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to the new design, many css variables changed. However, the cache buster value does not increase on Theming/Nextcloud upgrades which causes old theming stylesheets to remain cached. Thus, some apps on the Nextcloud instance look broken after an upgrade (to 30) until the cache is cleared.
How to reproduce?
stable29
and Calendarstable4.7
.debug
mode in config.php!master
and Calendar tomain
.Between steps 7 and 9 you can also observe that the content of theming stylesheets changes but not their cache buster hash (
?v=[...]
).Checklist