Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Correctly handle open file URL query #47015

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 3, 2024

Summary

There were 3 issues:

  1. The openfile is set on the query not as a param
  2. It is called openfile not openFile
  3. When redirecting to a file the viewer should open by default, so we need to set the openfile query on the redirect.

Sadly we can not really test this as the viewer is not included.

Screen recording

Bildschirmaufnahme_20240803_141453.webm

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… open by default

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit 50e6108 into master Aug 3, 2024
169 checks passed
@juliushaertl juliushaertl deleted the fix/open-file branch August 3, 2024 19:08
@susnux
Copy link
Contributor Author

susnux commented Aug 4, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Aug 4, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants