Fix: Update ConvertType.php to read correct DB params

[lwenderoth]

• Resolves: [Bug]: occ db:convert-type broken since PrimaryReadReplicaConnection support added #45257

Summary

Read connection defaults for $type instead of values for the current DB.
My first PR ever, tried my best to do it right..

[kesselb]

Changing createConnectionParams to createDefaultConnectionParams is not enough.

I assume the actual problem will be solved by #46931.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[susnux]

Changing createConnectionParams to createDefaultConnectionParams is not enough.

@kesselb but this is for the to database so we do not have any settings other than the defaults, no?

[kesselb]

but this is for the to database so we do not have any settings other than the defaults, no?

server/lib/private/DB/ConnectionFactory.php

Lines 203 to 221 in 77de180

	//additional driver options, eg. for mysql ssl
	$driverOptions = $this->config->getValue($configPrefix . 'dbdriveroptions', $this->config->getValue('dbdriveroptions', null));
	if ($driverOptions) {
	$connectionParams['driverOptions'] = $driverOptions;
	}
	// set default table creation options
	$connectionParams['defaultTableOptions'] = [
	'collate' => 'utf8_bin',
	'tablePrefix' => $connectionParams['tablePrefix']
	];
	if ($this->config->getValue('mysql.utf8mb4', false)) {
	$connectionParams['defaultTableOptions'] = [
	'collate' => 'utf8mb4_bin',
	'charset' => 'utf8mb4',
	'tablePrefix' => $connectionParams['tablePrefix']
	];
	}

dbdriveroptions and defaultTableOptions should be applied for the to database as well.
Without, the tables might be created with the wrong charset/collation or the connection is not possible (e.g. missing ssl)

[joshtrichards]

Related alternative PR (have not reviewed it yet): #48666