fix(files): Don't try to hash invalid paths #46845
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> fix: don't use OCP Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> fix: Also check if null Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
changed the title
There was a problem hiding this comment.
The null check on sourcePath is redundand since getSourcePath does not return null, and all the rest is already checked by hash_file function.
And getSourcePath is not supposed to return null, return type is string. Only in phpdoc though, we should make it strict.
This will not fix what you want it to fix in my opinion.
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
|
In my case, the file on disk (from the issue linked) was returning |
Still, hash_file would return false and not null. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
|
skjnldsv
added
2. developing
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
|
Closing as #46218 has been merged. |
Fix #44110
Summary
Another approach to #46218
This helps debug by adding logging statements to determine where null is being introduced, and force returning false in these cases.
Checklist