Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filecache queries compatible with sharding #46583

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Make filecache queries compatible with sharding #46583

merged 5 commits into from
Jul 19, 2024

Conversation

icewind1991
Copy link
Member

Various tweaks to the filecache queries to make them work with the upcoming sharding work

  • Use named parameters instead of positional ones
  • Explicitly filter by storage id in more places
  • Use parameters instead of literals
  • Remove redundant join condition

@icewind1991
fix: add set storage id for more cache queries
5ff7bde 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: always set storage id in Cache::get
80f8c79 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: make joining on tags in search queries work with sharding
ad88fd0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 17, 2024
@icewind1991 icewind1991 added this to the Nextcloud 30 milestone Jul 17, 2024
@icewind1991 icewind1991 requested review from blizzz, a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team July 17, 2024 13:52
@icewind1991 icewind1991 force-pushed the filecache-sharding-compat branch from 17ddec9 to 1843541 Compare July 17, 2024 14:40
@icewind1991 icewind1991 force-pushed the filecache-sharding-compat branch from 1843541 to d9da5e8 Compare July 17, 2024 15:56
@icewind1991
fix: make usermountcache compatible with sharding
0931492 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: make batch propagator work with sharding restrictions
c5b6872 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the filecache-sharding-compat branch from d9da5e8 to c5b6872 Compare July 17, 2024 17:16
artonge
artonge approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, good anyway, it is just a question :)

@icewind1991 icewind1991 enabled auto-merge July 18, 2024 15:26
@icewind1991 icewind1991 merged commit 64ca4b8 into master Jul 19, 2024
166 checks passed
@icewind1991 icewind1991 deleted the filecache-sharding-compat branch July 19, 2024 07:49
@ChristophWurst
Copy link
Member

Yes? :)

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorbaugh sorbaugh sorbaugh approved these changes

@artonge artonge artonge approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @ChristophWurst @artonge @sorbaugh