Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(htaccess): Serve images as static assets #46543

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(htaccess): Serve images as static assets #46543

merged 1 commit into from
Jul 16, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 15, 2024

Summary

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Jul 15, 2024

I hope this fixes the daily instance not serving images correctly (especially webp).

Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but guess needs an htaccess update on daily then.

@susnux
Copy link
Contributor Author

susnux commented Jul 15, 2024

@SystemKeeper yes probably but maybe even some Caddy config update.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@susnux
Copy link
Contributor Author

susnux commented Jul 16, 2024

But I do not think this is the root cause as locally deployed with Apache it works, only the daily instance with Caddy seems to have problem :(

@susnux
Copy link
Contributor Author

susnux commented Jul 16, 2024

(I mean it is an improvement anyways)

@susnux susnux merged commit bcfe566 into master Jul 16, 2024
166 checks passed
@susnux susnux deleted the fix/htaccess branch July 16, 2024 09:52
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants