Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(theming): Conitionally disable blur filter for performance #46431

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 10, 2024

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from susnux July 10, 2024 22:37
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Jul 10, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.8 milestone Jul 10, 2024
@susnux susnux changed the title [stable28] [stable29] fix(theming): Conitionally disable blur filter for performance [stable28] fix(theming): Conitionally disable blur filter for performance Jul 10, 2024
@susnux
Copy link
Contributor

susnux commented Jul 10, 2024

/compile amend/

@susnux susnux marked this pull request as ready for review July 10, 2024 22:48
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@Altahrim Altahrim mentioned this pull request Jul 11, 2024
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 11, 2024
@AndyScherzinger
Copy link
Member

/compile /

susnux and others added 3 commits July 11, 2024 18:23
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Jul 11, 2024

There was a backport artifact in the test, fixed that and the failing test now works locally:
Bildschirmfoto_20240711_182311

@AndyScherzinger AndyScherzinger merged commit e8b4d4e into stable28 Jul 11, 2024
54 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/46258/stable28 branch July 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants