Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace dashboard icon with Material Symbols #46215

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: Replace dashboard icon with Material Symbols #46215

merged 1 commit into from
Jul 2, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 1, 2024 •
edited
Loading

Summary

Currently we use a circle as the dashboard icon,

  1. This confuses with the circles app
  2. Does not really gives information what this app does
  3. Is not consistent with our app stores

So make it consistent and use the "dashboard" Material Symbol everywhere.

Screenshot

Bildschirmfoto_20240701_120954

Checklist

@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jul 1, 2024
szaimen
szaimen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@susnux susnux force-pushed the enh/dashboard-icon branch from 4dc3ff7 to 22e0c6b Compare July 1, 2024 10:39
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jul 1, 2024
@susnux susnux force-pushed the enh/dashboard-icon branch from 22e0c6b to b18293a Compare July 1, 2024 11:38
jancborchardt
jancborchardt reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, the circle is a reference to the Nextcloud logo, and as the dashboard being the center of your stuff.

Yes the new dashboard icon is a more visual representation of what it is / how it looks like. Either is fine with me.

@susnux
Copy link
Contributor Author

susnux commented Jul 1, 2024

Just FYI, the circle is a reference to the Nextcloud logo, and as the dashboard being the center of your stuff.

I was told that and some other places, but I think you do not notice it anymore as there are too many apps.
But this is why I requested reviews of all @nextcloud/designers as this is purely a design decision :)

@susnux
chore: Replace dashboard icon with Material Symbols
2249d7d 
Currently we use a circle as the dashboard icon,
1. This confuses with the circles app
2. Does not really gives information what this app does
3. Is not consistent with our app stores

So make it consistent and use the "dashboard" Material Symbol everywhere.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the enh/dashboard-icon branch from b18293a to 2249d7d Compare July 1, 2024 21:41
@AndyScherzinger AndyScherzinger merged commit d4cb51c into master Jul 2, 2024
110 checks passed
@AndyScherzinger AndyScherzinger deleted the enh/dashboard-icon branch July 2, 2024 16:46
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@szaimen szaimen szaimen approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@susnux @jancborchardt @AndyScherzinger @marcoambrosini @szaimen