Signed requests

[ArtificialOwl]

Signed Request

Signing request allows to confirm the identity of the sender.
Signing request does not encrypt nor affect its payload.
Signing request only adds metadata to the headers of the request.

Signature

The concept is to add unique metadata and sign them using a private/public key pair.
The location of the public key used to verify the signature will confirm the origin of the request.

Signature does not affect the data of the request, it only adds headers to it:

 {
     "(request-target)": "post /path",
     "content-length": 380,
     "date": "Mon, 08 Jul 2024 14:16:20 GMT",
     "digest": "SHA-256=U7gNVUQiixe5BRbp4Tg0xCZMTcSWXXUZI2\\/xtHM40S0=",
     "host": "hostname.of.the.recipient",
     "Signature": "keyId=\"https://author.hostname/ocm#signature\",algorithm=\"sha256\",headers=\"request-target) content-length date digest host\",signature=\"DzN12OCS1rsA[...]o0VmxjQooRo6HHabg==\""
 }

• 'content-length' is the total length of the data/content
• 'date' is the datetime the request have been initiated
• 'digest' is a checksum of the data/content
• 'host' is the hostname of the recipient of the request (remote when signing outgoing request, local on incoming request)
• 'Signature' contains the signature generated using the private key, and metadata:
  • 'keyId' is a unique id, formatted as an url. hostname is used to retrieve the public key via custom discovery
  • 'algorithm' define the algorithm used to generate signature
  • 'headers' contains a list of element used during the generation of the signature
  • 'signature' is the encrypted string, using local private key, of an array containing elements
    listed in 'headers' and their value. Some elements (content-length date digest host) are mandatory
    to ensure authenticity override protection.

(Those are the minimum required headers, some can be added via options during the process)

ISignatoryManager

Because each protocol have different ways to obtain the public key of a remote instance or entity, some part of the signing/verifying process is managed by a custom provider, one for each protocol.

• getProviderId should returns a unique string

• getOptions can returns an array that can contains those entries:

  • 'ttl' (300) is the lifetime (in secondes) of the signature
  • 'ttlSignatory' (86400*3) the cache lifetime on a remote signatory
  • 'extraSignatureHeaders' ([]) (list of extra headers to include to the signature)
  • 'algorithm' ('sha256') is the algorithm used to generate the signature
  • 'dateHeader' ("D, d M Y H:i:s T") the format of the 'date' header

• getLocalSignatory should return the local signatory, including the full (public+private) key pair.

• getRemoteSignatory should returns a remote signatory based on the requested data, must at least contains key id and public key

ISignatureManager

ISignatureManager is a service integrated to core that provide tools to set/get authenticity of/from outgoing/incoming requests.

• getIncomingSignedRequest extract data from the incoming request and compare headers to confirm authenticity of remote instance
• getOutgoingSignedRequest prep signature to sign an outgoing request.
• signOutgoingRequestIClientPayload is the one method to call to fully process of signing and fulfilling the payload for an outgoing request using IClient
• searchSignatory get a remote signatory from the database

[nickvergessen]

sharedSecret inside the notification is already used by some OCM messages. So this would break it. Can you take another key? Or maybe you prefix with '$#$' or something alike?

[ArtificialOwl]

this would not break it as I send the exception for the exact same reason of a missing 'sharedSecret' entry in the notifications request. The only thing is that I do this check earlier than others but I can add a prefix if you want (while I dont feel like necessary myself)

[nickvergessen]

this would not break it as I send the exception for the exact same reason of a missing 'sharedSecret' entry in the notifications request.

Nextcloud Talk is sending a data field 'sharedSecret' and you either overwrite that and it breaks Talk Federation with older servers or you need to use a different key

[ArtificialOwl]

As said before, I only use this entry because it exists in the OCM protocol and doing so to compare that the origin of the reshare request, based on the token (and the linked recipient stored in the database), confirm the identity used to sign the request.

If Talk is using this endpoint to initiate anything, signature are to be required

.

[nickvergessen]

mysql> DESCRIBE oc_sec_signatory;
+--------------+-----------------+------+-----+---------+----------------+
| Field        | Type            | Null | Key | Default | Extra          |
+--------------+-----------------+------+-----+---------+----------------+
| id           | bigint unsigned | NO   | PRI | NULL    | auto_increment |
| key_id_sum   | varchar(127)    | NO   | MUL | NULL    |                |
| key_id       | varchar(512)    | NO   |     | NULL    |                |
| host         | varchar(512)    | NO   |     | NULL    |                |
| provider_id  | varchar(31)     | NO   | MUL | NULL    |                |
| account      | varchar(127)    | YES  |     |         |                |
| public_key   | longtext        | NO   |     | NULL    |                |
| metadata     | longtext        | NO   |     | NULL    |                |
| type         | smallint        | NO   |     | 9       |                |
| status       | smallint        | NO   |     | 0       |                |
| creation     | int unsigned    | YES  |     | 0       |                |
| last_updated | int unsigned    | YES  |     | 0       |                |
+--------------+-----------------+------+-----+---------+----------------+
12 rows in set (0,00 sec)

Seems this does not work. TEXT fields can not have a default.

[nickvergessen]

This breaks Talk integration tests on:
MySQL

{"Exception":"OC\\DB\\Exceptions\\DbalException","Message":"An exception occurred while executing a query: SQLSTATE[HY000]: General error: 1364 Field 'metadata' doesn't have a default value"

[juliusknorr]

I think there is another failure with oracle catched by richdocuments integration tests:

{"Exception":"Exception","Message":"Cannot assign null to property NCU\\Security\\Signature\\Model\\Signatory::$account of type string in file '\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/Entity.php' line 149","Code":0,"Trace":[{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/AppFramework\/App.php","line":161,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/Route\/Router.php","line":306,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/base.php","line":1019,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/index.php","line":24,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/AppFramework\/Http\/Dispatcher.php","Line":146,"Previous":{"Exception":"TypeError","Message":"Cannot assign null to property NCU\\Security\\Signature\\Model\\Signatory::$account of type string","Code":0,"Trace":[{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/Entity.php","line":59,"function":"setter","class":"OCP\\AppFramework\\Db\\Entity","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/QBMapper.php","line":315,"function":"fromRow","class":"OCP\\AppFramework\\Db\\Entity","type":"::"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/QBMapper.php","line":375,"function":"mapRowToEntity","class":"OCP\\AppFramework\\Db\\QBMapper","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/Security\/Signature\/Db\/SignatoryMapper.php","line":56,"function":"findEntity","class":"OCP\\AppFramework\\Db\\QBMapper","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/Security\/Signature\/SignatureManager.php","line":326,"function":"getByKeyId","class":"OC\\Security\\Signature\\Db\\SignatoryMapper","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/Security\/Signature\/SignatureManager.php","line":140,"function":"getStoredSignatory","class":"OC\\Security\\Signature\\SignatureManager","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/Security\/Signature\/SignatureManager.php","line":108,"function":"confirmIncomingRequestSignature","class":"OC\\Security\\Signature\\SignatureManager","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/apps\/cloud_federation_api\/lib\/Controller\/RequestHandlerController.php","line":339,"function":"getIncomingSignedRequest","class":"OC\\Security\\Signature\\SignatureManager","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/apps\/cloud_federation_api\/lib\/Controller\/RequestHandlerController.php","line":104,"function":"getSignedRequest","class":"OCA\\CloudFederationAPI\\Controller\\RequestHandlerController","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":200,"function":"addShare","class":"OCA\\CloudFederationAPI\\Controller\\RequestHandlerController","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":114,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/AppFramework\/App.php","line":161,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/private\/Route\/Router.php","line":306,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/base.php","line":1019,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/index.php","line":24,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/Entity.php","Line":149},"message":"Cannot assign null to property NCU\\Security\\Signature\\Model\\Signatory::$account of type string in file '\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/Entity.php' line 149","exception":{},"CustomMessage":"Cannot assign null to property NCU\\Security\\Signature\\Model\\Signatory::$account of type string in file '\/home\/runner\/actions-runner\/_work\/richdocuments\/richdocuments\/lib\/public\/AppFramework\/Db\/Entity.php' line 149"}