Fix rmdir() to release possible directory lock prior to removing directory #45967
Conversation
…induced by underlying storage engine (e.g. VirtualBox shared folder) Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
solracsf
requested review from
a team,
ArtificialOwl,
yemkareems,
sorbaugh and
come-nc
and removed request for
a team
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
| @@ -117,6 +117,7 @@ public function rmdir($path) { | |||
| } | |||
| $it->next(); | |||
| } | |||
| unset($it); | |||
There was a problem hiding this comment.
That needs a comment to explain what it does.
There was a problem hiding this comment.
Please see first commit message, I do not understand what else I need to explain about unsetting the iterator to free the directory lock.
There was a problem hiding this comment.
You need to explain it in the code with a comment.
Otherwise this will get removed later or confuse future code readers.
There was a problem hiding this comment.
Sorry I seem to have closed and messed up this PR, don;t know how I did that.
However, I reset the branch with a single proper commit with the desired comment, can you reopen this PR or should I create a new one with it?
There was a problem hiding this comment.
Never mind, I created a new PR.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
As described in this Nextcloud community issue some storage systems (such as VirtualBox shared folders) may lock a directory when traversing it using
opendir()or aDirectoryIterator. This patch fixesLocal::rmdir()to release such locks prior to removing a directory recursively, avoiding failure to do so with 'Text file busy" warnings.