Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license information extracted from built assets #45952

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

AndyScherzinger
Copy link
Member

… until new versions are published shipping the SPDX listed license strings

  • Resolves: # wrong SPDX license identifiers are overwritten

Summary

TODO

  • compile

Checklist

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jun 18, 2024
@AndyScherzinger AndyScherzinger force-pushed the fix/noid/spdxLicenseIdentifier branch from 6680155 to cb83e96 Compare June 18, 2024 14:09
@AndyScherzinger
Copy link
Member Author

/compile /

AndyScherzinger and others added 2 commits June 18, 2024 16:55
… SPDX listed license strings

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ained

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/noid/spdxLicenseIdentifier branch from ab96ad7 to 8e7cdf3 Compare June 18, 2024 14:55
susnux and others added 3 commits June 18, 2024 17:28
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux force-pushed the fix/noid/spdxLicenseIdentifier branch from 8e7cdf3 to ef8937d Compare June 18, 2024 15:28
@susnux susnux changed the title Hard-wire licenses Fix license information extracted from built assets Jun 18, 2024
@susnux
Copy link
Contributor

susnux commented Jun 18, 2024

@AndyScherzinger

# FEHLENDE URHEBERRECHTS- UND LIZENZINFORMATIONEN

Die folgenden Dateien haben keine Urheberrechts- und Lizenzinformationen:
* apps/dashboard/css/dashboard.css.map
* apps/encryption/css/settings-personal.css.map
* apps/files/css/detailsView.css.map
* apps/files/css/files.css.map
* apps/files/css/merged.css.map
* apps/files/css/mobile.css.map
* apps/files/css/upload.css.map
* apps/files_external/css/settings.css.map
* apps/files_sharing/css/icons.css.map
* apps/files_sharing/css/mobile.css.map
* apps/files_sharing/css/public.css.map
* apps/files_sharing/css/publicView.css.map
* apps/oauth2/appinfo/info.xml
* apps/user_status/css/user-status-menu.css.map
* dist/preview-service-worker.js


# ZUSAMMENFASSUNG

* Falsche Lizenzen: 0
* Veraltete Lizenzen: 0
* Lizenzen ohne Dateiendung: 0
* Fehlende Lizenzen: BSD-3-Clause, MPL-2.0, AGPL-3.0, ISC, CC-BY-4.0, BSD-2-Clause
* Unbenutzte Lizenzen: 0
* Verwendete Lizenzen: LicenseRef-FacebookTrademarks, MIT, AGPL-3.0-or-later, Apache-2.0, MPL-2.0, LicenseRef-Nasa, AGPL-3.0-only, CC-BY-SA-3.0, GPL-3.0-or-later, LicenseRef-Unsplash, LicenseRef-CollaboraTrademarks, CC-BY-2.0, ISC, LicenseRef-DiasporaTrademarks, CC-BY-SA-2.0, CC-BY-SA-4.0, BSD-3-Clause, CC0-1.0, LicenseRef-GooglePlayBadge, LicenseRef-freepikLicense, LicenseRef-XTrademarks, LicenseRef-NextcloudTrademarks, OFL-1.1, OFL-1.1-RFN, LicenseRef-MastodonTrademarks, CC-BY-SA-3.0-IGO, CC-BY-4.0, LicenseRef-DCO, BSD-2-Clause, AGPL-3.0, LicenseRef-AppleAppStoreBadge
* Lesefehler: 0
* Dateien mit Urheberrechtsinformationen: 11059 / 11074
* Dateien mit Lizenzinformationen: 11059 / 11074

@susnux
Copy link
Contributor

susnux commented Jun 18, 2024

dist/preview-service-worker.js

This one if generated by a webpack plugin, so I guess MIT by Google, ref: https://github.com/GoogleChrome/workbox

@AndyScherzinger
Copy link
Member Author

This one if generated by a webpack plugin, so I guess MIT by Google, ref: https://github.com/GoogleChrome/workbox

@susnux I would say so too, yes 👍

@susnux
Copy link
Contributor

susnux commented Jun 18, 2024

This one if generated by a webpack plugin, so I guess MIT by Google, ref: https://github.com/GoogleChrome/workbox

I would say so too, yes 👍

@AndyScherzinger Then I would say add it to de5 😉

@AndyScherzinger AndyScherzinger added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jun 18, 2024
@AndyScherzinger
Copy link
Member Author

Will do in follow up 👍

@AndyScherzinger AndyScherzinger merged commit ee6ddb9 into master Jun 18, 2024
109 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/noid/spdxLicenseIdentifier branch June 18, 2024 21:32
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants