perf: Avoid reusing previous migration steps #45945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running an upgrade we have several stages that might trigger repair steps.
Repair::getBeforeUpgradeRepairSteps()
The Repair class has no default migration steps and there are both a setRepair and addStep methods, however for the case when we upgrade an app we do not need to run core migrations again.
This fix will ensure that after running we always empty the list of repair steps stored in the Repair class instance.
I also checked usages and for all other places we tend to overwrite the array anyways.
Also if the app has no steps itself it would skip the core migrations still around before this change anyways.
Checklist