Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(ObjectStore): Fix regression when hostname is empty #45839

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[stable28] fix(ObjectStore): Fix regression when hostname is empty #45839

merged 1 commit into from
Jun 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 12, 2024

Backport of PR #45649

@backportbot backportbot bot added this to the Nextcloud 28.0.7 milestone Jun 12, 2024
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 12, 2024
@blizzz blizzz mentioned this pull request Jun 13, 2024
Merged
6 tasks
@joshtrichards @kesselb
fix(ObjectStore): handle empty S3 hostname
d285ade 
Fixes #45637

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

Signed-off-by: Josh <josh.t.richards@gmail.com>
@AndyScherzinger AndyScherzinger merged commit e1af6af into stable28 Jun 13, 2024
52 of 54 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/45649/stable28 branch June 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes

@susnux susnux susnux approved these changes

@kesselb kesselb kesselb approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@joshtrichards joshtrichards

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: object storage
Projects
None yet
Milestone
Nextcloud 28.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@joshtrichards @susnux @kesselb @AndyScherzinger