fix restore of multiple folders with many files from trash_bin #45761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #44504 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
requested review from
artonge,
a team,
ArtificialOwl and
yemkareems
and removed request for
a team
|
would backport if approved |
|
I assume the retry logic does not work because the wrong exception is caught. |
🧠 So maybe unwrapping the exception would be enough? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes restore from trash bin of multiple folders with many files inside them
switch the DB statement execution method
related to #44504
Some tests were carried, and this simple change seems to fix the issue.