Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(files): Only execute default action if there is an action to perform #45663

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 4, 2024

Backport of #45586

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, skjnldsv and susnux June 4, 2024 13:50
@backportbot backportbot bot added this to the Nextcloud 28.0.7 milestone Jun 4, 2024
@susnux susnux marked this pull request as ready for review June 4, 2024 13:59
@susnux susnux enabled auto-merge June 4, 2024 14:00
@susnux
Copy link
Contributor

susnux commented Jun 4, 2024

/compile

Some files do not have a default action (can not be viewed and only downloaded).
If the `openfile` query is set on them the `handleOpenFile` will throw an error.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv disabled auto-merge June 4, 2024 15:14
@skjnldsv skjnldsv merged commit a8d3179 into stable28 Jun 4, 2024
41 of 44 checks passed
@skjnldsv skjnldsv deleted the backport/45586/stable28 branch June 4, 2024 15:14
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2024
@blizzz blizzz mentioned this pull request Jun 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants