Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(files): Implement SortingService to fix sorting of files #45533

Merged
merged 2 commits into from
May 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 27, 2024

Backport of #45419

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from skjnldsv, szaimen and susnux May 27, 2024 14:43
@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone May 27, 2024
@susnux
Copy link
Contributor

susnux commented May 27, 2024

/compile amend/

@susnux susnux force-pushed the backport/45419/stable28 branch 2 times, most recently from f418303 to 73576ae Compare May 27, 2024 14:59
@susnux susnux marked this pull request as ready for review May 27, 2024 14:59
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

The previously used library was parsing strings to try to detect dates,
but for filenames it makes no sense to parse them as dates.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 8f0bbcd into stable28 May 28, 2024
45 checks passed
@susnux susnux deleted the backport/45419/stable28 branch May 28, 2024 20:10
@blizzz blizzz mentioned this pull request Jun 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants